Conversation
- FSharp.Control.TaskSeq: 0.4.0 → 1.1.1 (latest published) - FsToolkit.ErrorHandling.TaskResult: 4.15.1 → 4.18.0 The SmokeTests reference the published NuGet package to verify API compatibility. Keeping the reference at 0.4.0 while the library is at 1.1.1 means the smoke tests were only verifying a very old API surface. Updating to 1.1.1 ensures the smoke tests cover the current published API. All 11 smoke tests pass with both updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
24 tasks
dsyme
deleted the
repo-assist/eng-smoketests-deps-20260423-e03d35ff45e377c7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
The SmokeTests project references the published NuGet package to verify that the API surface works correctly from a consumer's perspective. However, the
FSharp.Control.TaskSeqreference was pinned to0.4.0— seven minor versions behind the current published1.1.1. This means the smoke tests were only validating a very old API surface and would miss any regressions in API that was added in0.6.0,1.0.0,1.1.0, or1.1.1.Changes
FSharp.Control.TaskSeq0.4.01.1.1FsToolkit.ErrorHandling.TaskResult4.15.14.18.0xunit.runner.visualstudioremains at2.8.2— this is the latest 2.x release (3.x is for xunit v3, which the project does not use).Test Status
dotnet build src/FSharp.Control.TaskSeq.SmokeTests -c Release— succeeded (0 warnings, 0 errors, packages resolved from NuGet)dotnet test src/FSharp.Control.TaskSeq.SmokeTests -c Release— 11 passed, 0 failed